feat: support subbuffer size option #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymski
force-pushed
the
support_subbuffer_size_option
branch
3 times, most recently
from
9adefd1
to
2b5a9fb
Compare
isp-uetsuki
requested changes
Aug 23, 2023
nabetetsu
previously approved these changes
Sep 1, 2023
There was a problem hiding this comment.
LGTM 👍
I have tested ros2 caret record command in iron environment.
when specifing --subbuffer-size-{ust,kernel} option:
ros2 caret record --subbuffer-size-ust 65536 --subbuffer-size-kernel 65536
UST tracing enabled (1 events)
kernel tracing disabled
context (3 fields)
writing tracing session to: /root/.ros/tracing/session-20230901023936
press enter to start...
subbuffer ust = 65536
subbuffer kernel = 65536
press enter to stop...
stopping & destroying tracing session
without any option:
# ros2 caret record
UST tracing enabled (1 events)
kernel tracing disabled
context (3 fields)
writing tracing session to: /root/.ros/tracing/session-20230901023906
press enter to start...
subbuffer ust = 32768
subbuffer kernel = 131072
press enter to stop...
stopping & destroying tracing session
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
Co-authored-by: isp-uetsuki <[email protected]>
Signed-off-by: yamasaki <[email protected]>
ymski
force-pushed
the
support_subbuffer_size_option
branch
from
d0aa069
to
0359359
Compare
|
Conflict occurred because another PR was merged. |
nabetetsu
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In caret, the lttng buffer size was hard-coded in the forked ros2_tracing.
This was done to prevent trace data from being lost.
In ros2_tracing since iron, it is possible to change the buffer size of lttng externally.
This PR provides an option to specify the buffer size from the ros2caret cli.
usage:
Related links
Notes for reviewers
ros2/ros2_tracing#51
This PR must be merged after #84.
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.